Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trunner: imxrt117x unify DAP link device search #377

Merged
merged 1 commit into from
Oct 7, 2024
Merged

trunner: imxrt117x unify DAP link device search #377

merged 1 commit into from
Oct 7, 2024

Conversation

maska989
Copy link
Contributor

@maska989 maska989 commented Oct 7, 2024 •
edited
Loading

JIRA: CI-500

Description

New revision of board use different vendor / product ID for DAP link. To make sure that we select proper USB device, we need to change finding raw VID/PID to "CMSIS-DAP" (On both revision this word can be used to determinate which one is DAP link USB device)

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (refactoring, style fixes, git/CI config, submodule management, no code logic changes)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: armv7m7-imxrt117x-evk.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

  • This PR needs additional PRs to work (list the PRs, preferably in merge-order).
  • I will merge this PR by myself when appropriate.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 7, 2024 •
edited
Loading

Unit Test Results

7 725 tests  ±0   7 010 ✅ ±0   38m 41s ⏱️ + 3m 21s
  445 suites ±0     715 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit 7746bf8. ± Comparison against base commit c3b2ba6.

♻️ This comment has been updated with latest results.

damianloew
damianloew reviewed Oct 7, 2024
View reviewed changes
Copy link
Contributor

@damianloew damianloew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please leave a few words why this change is needed (the newer imxrt117x boards marked as EVKB have a different onboard programmer, we want to support them too)

@maska989 maska989 force-pushed the maska989/adjust_imx117x_findport branch 4 times, most recently from d7cbcf1 to b5aa6c4 Compare October 7, 2024 10:03
damianloew
damianloew requested changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@damianloew damianloew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add newline after commit description

@maska989 maska989 force-pushed the maska989/adjust_imx117x_findport branch 2 times, most recently from a7b4a62 to 32eb9b8 Compare October 7, 2024 10:14
@maska989
trunner: armv7m7 unify DAP link device search
7746bf8 
Change provided for new revisions of boards with different vid/pid configuration.

JIRA: CI-500
@maska989 maska989 force-pushed the maska989/adjust_imx117x_findport branch from 32eb9b8 to 7746bf8 Compare October 7, 2024 10:16
@damianloew damianloew merged commit aba8104 into master Oct 7, 2024
37 checks passed
@damianloew damianloew deleted the maska989/adjust_imx117x_findport branch October 7, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damianloew damianloew damianloew approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maska989 @damianloew